Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comprehensive node-addon-api test suite #163

Closed
15 of 33 tasks
anisha-rohra opened this issue Oct 25, 2017 · 14 comments
Closed
15 of 33 tasks

Comprehensive node-addon-api test suite #163

anisha-rohra opened this issue Oct 25, 2017 · 14 comments

Comments

@anisha-rohra
Copy link

anisha-rohra commented Oct 25, 2017

  • Array
    • Array
    • TypedArray
    • TypedArrayOf
  • ArrayBuffer
  • AsyncWorker
  • Boolean
  • Buffer
  • CallbackInfo
  • Constructor
  • Conversions
  • Error
    • Error
    • RangeError
    • TypeError
  • External
  • Function
  • FunctionReference (@NickNaso)
  • HandleScope
  • Name
  • Number
  • Napi Child
  • Object (@romandev)
  • ObjectReference
  • ObjectWrap
    • DefineClass
  • PropertyDescriptor
  • RangeError
  • Reference (@anisha-rohra)
  • String
  • Symbol
  • Value
  • abi-stable-node-addon-examples imported

Would appreciate any input on test cases that need to added and/or removed from this list, attempting to make it as comprehensive as possible!

@jschlight
Copy link
Contributor

I'm working on the documentation and it would be helpful for my work to have test cases for Reference.

@mhdawson
Copy link
Member

@anisha-rohra can you prioritize adding the test for Reference ?

@mhdawson
Copy link
Member

mhdawson commented Nov 2, 2017

@jschlight talked to @anisha-rohra earlier in the week to get her up to speed on Reference, should be working on it now.

@romandev
Copy link
Contributor

romandev commented Nov 2, 2017

@mhdawson, @anisha-rohra Can I also work on this issue together? (but I don't want to get in the way)

@romandev
Copy link
Contributor

romandev commented Nov 2, 2017

Also, can we split a large test into smaller tests?
For example, if we are writing tests for Object wrapper, there are too many methods in Object class.
So, if we put all tests into one file, I think readability will be poor and complexity will increase.

@mhdawson
Copy link
Member

mhdawson commented Nov 3, 2017

@romandev absolutely. Splitting out if there are a lot of tests also makes sense to me.

To grab one of the sections, just post a comment here with the ones you are working on so that other people wont' work on them at the same time. We'll try to periodically update the top part with that information as well.

@romandev
Copy link
Contributor

romandev commented Nov 4, 2017

@mhdawson Sure, if so, I'll start to write a test for Object first. It has been marked as complete but still missed many APIs.

@mhdawson
Copy link
Member

mhdawson commented Nov 7, 2017

@romandev sounds good.

@romandev
Copy link
Contributor

Is anyone working on Reference test? If there is no one, can I take it?

@anisha-rohra
Copy link
Author

@romandev I'm taking a look at it at the moment! Should be done in a couple of days.

@mhdawson
Copy link
Member

mhdawson commented Jan 5, 2018

@romandev I know you contributed a number of tests for Object. Should I mark it as complete above ?

@romandev
Copy link
Contributor

romandev commented Jan 8, 2018

@mhdawson Yep, I think we can mark it as complete :) Thank you.

@NickNaso
Copy link
Member

NickNaso commented Sep 7, 2018

Hi @mhdawson I think that we need to close this issue and use the new #332

@mhdawson
Copy link
Member

@NickNaso I think that makes sense a as more detailed list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants