Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Node.js v0.8.x from Travis CI. #826

Merged
merged 1 commit into from
Nov 15, 2018
Merged

Drop Node.js v0.8.x from Travis CI. #826

merged 1 commit into from
Nov 15, 2018

Conversation

bnoordhuis
Copy link
Member

node-gyp v3.6.3 doesn't work with node.js v0.8.28 any longer and
therefore the test suite doesn't build. As that is outside our
control, drop it.

In fact, it's a dependency of node-gyp that stopped working but
that is immaterial, the net result is the same.

@bnoordhuis
Copy link
Member Author

@agnat @kkoopa Quick LGTM, por favor?

Copy link
Collaborator

@agnat agnat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

node-gyp v3.6.3 doesn't work with node.js v0.8.28 any longer and
therefore the test suite doesn't build. As that is outside our
control, drop it.

In fact, it's a dependency of node-gyp that stopped working but
that is immaterial, the net result is the same.

PR-URL: #826
Reviewed-By: David Siegel <agnat@me.com>
@bnoordhuis bnoordhuis merged commit 02888e1 into nodejs:master Nov 15, 2018
@bnoordhuis bnoordhuis deleted the drop-v0.8 branch November 15, 2018 21:08
@bnoordhuis
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants