Fix Node.js v10.12.0 deprecation warnings. #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flarna
reviewed
Nov 13, 2018
nan_implementation_12_inl.h
Outdated
| @@ -337,7 +345,23 @@ Factory<v8::StringObject>::New(v8::Local<v8::String> value) { | |||
| #if V8_MAJOR_VERSION >= 7 | |||
There was a problem hiding this comment.
At the other locations this #if was replaced by #if NODE_MAJOR_VERSION >= 10. Is it kept intentionally here?
There was a problem hiding this comment.
Yes. Should I add a comment?
There was a problem hiding this comment.
Up to you.
Personally I find the #ifs on V8 version not nice as it indicates that it breaks the API/ABI stability within a major nodejs version.
There was a problem hiding this comment.
Yeah, I agree. I've pushed a new commit that removes it, PTAL.
|
Rebased onto master. The CI should be passing now that #826 is merged. |
|
Nice job! LGTM. |
This commit was brought to you by `perl -i -pe` (well, mostly - I did some manual fixups.) PR-URL: #825 Reviewed-By: Benjamin Byholm <bbyholm@abo.fi>
|
Thanks for the review, Benjamin. Landed in e6ef6a4...e222068. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v10.12.0 turns on a number of V8 deprecation warnings. This commit fixes
them in NAN.
Fixes: #810
Refs: #811