-
Notifications
You must be signed in to change notification settings - Fork 40
Conversation
Co-Authored-By: Vanessa Yuen <vanessayuenn@github.com>
Co-Authored-By: Vanessa Yuen <vanessayuenn@github.com>
@zeke @vanessayuenn holy smokes! This is amazing!!! Thank you for starting us off on such a great foot! Can't wait to get this synced with Crowdin asap! 🙌 |
Note that as we add new versions of node's docs (e.g 9.9.1 when that comes out) we can configure a Crowdin workflow that applies all existing translations from the Translation Memory. This way translators will only need to translate content that has changed between versions. |
See also this Electron issue where we ponder what Electron versions to localize: electron/i18n#288 |
I made a few updates:
|
Taking |
Hi @zeke , I try to run this script (on Windows), but I receive 404 (Not Found) because of the wrong url
If I remove
But then I receive this error during moving docs from temp dir, it probably should by copied to the destination folder
|
Thanks for giving it a go, @lukaszewczak and @FranzDeCopenhague. Should be fixed now. Can you give it another try? I was waffling between having the semver.valid('v1.2.3') // true |
@lukaszewczak I wanna see if this is indeed a permissions error, or just a byproduct of the |
Thanks @FranzDeCopenhague, though I kind of wanted to get more feedback from other reviewers, but I suppose we can iterate from here in new pull requests. I opened #59 where we can discuss PR review requirements. |
@zeke, I did wait, a little, for @lukaszewczak feedback and move on because the issue looks like a windows problem where the temp folder is at a different unit drive to the i18n project |
This sounds familiar. See electron/get#36 -- I agree that we should download to the repo directory. |
Of course! Did you mean me or you, though? :) |
Me :-) I will try to prepare it:-) |
This PR is a first step toward collecting source content from the nodejs/node repo to be synced with Crowdin. The
collect
script uses semver.io to determine the "Current" version of Node.js, but we should discuss which versions we want to collect, and how to structure them in this repo.The diff is a bit noisy because of the imported content. To see just the code changes, check out this commit: 2c2c14c
Considerations
/doc
directory, but it might be prudent to only import.md
files and ignore things like images. This is what we do on electron/18n, and we rewrite relativesrc
andhref
attributes when generated theelectron-i18n
module that's consumed by the website.cc @nodejs/i18n
🍐 with @vanessayuenn