Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

continuous integration #58

Closed
zeke opened this issue Mar 29, 2018 · 6 comments
Closed

continuous integration #58

zeke opened this issue Mar 29, 2018 · 6 comments

Comments

@zeke
Copy link
Contributor

zeke commented Mar 29, 2018

#55 introduces code into this repository. It would be great if we could run tests on it. I don't know much about CI integration works in the @nodejs org.

@LaurentGoderre
Copy link
Member

The docker node group uses Travis CI

@zeke
Copy link
Contributor Author

zeke commented Mar 29, 2018

👋 @mcollina I see you on a few CI-related issues around the org. Can you shed some light on the matter?

@mcollina
Copy link
Member

Hey @zeke, I'm not involved in keeping up the CI. You should talk to @nodejs/build.

@MylesBorins
Copy link

@zeke we traditionally have allowed integrations on a per case basic. There is prior art for travisCI for example.

Node core uses ci.nodejs.org, a custom Jenkins setup. That system is really only necessary if you are needing to test on specific platforms unsupported by travis.

I think opening an issue on github.com/nodejs/build should be sufficient to get travis enabled here. We need to also open an issue on the TSC repo to talk about updating our bot policy.

@zeke
Copy link
Contributor Author

zeke commented May 15, 2018

A PR is in the works: nodejs/github-bot#171

@zeke
Copy link
Contributor Author

zeke commented May 31, 2018

Travis is set up! See #94

@zeke zeke closed this as completed May 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants