Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt-backport: unlabel and clean labeling #104

Conversation

Fishrock123
Copy link
Contributor

Should fix #100 (comment) while also giving a way to see when a PR update has changed the backportability.

This was always on the plans, I just hadn't gotten to it before.

cc @phillipj and maybe also @thealphanerd

I don't really trust myself that it'l work without testing though, but I have a plan on how to test the script, so I'm going to do that next and then rebase this ontop.

phillipj

This comment was marked as off-topic.

@Fishrock123 Fishrock123 force-pushed the attempt-backport-unlabel-and-clean-labeling branch 2 times, most recently from e25c998 to 9acb63e Compare December 14, 2016 15:03
phillipj

This comment was marked as off-topic.

phillipj

This comment was marked as off-topic.

@phillipj
Copy link
Member

Other than my recent negate comments, this LGTM

@Fishrock123
Copy link
Contributor Author

@phillipj On second look I think my previous checks were wrong. We only want to remove it if we added it.

@phillipj
Copy link
Member

@Fishrock123 not sure I follow you.. If we only want the bot to remove labels it added itself previously, that still means my .includes() comments are valid?

If I understand the current code correctly, labels added by the bot will not be removed since it will prevent removeLabelFromPR() from being reached if the label in question was actually added by the bot.

@Fishrock123 Fishrock123 force-pushed the attempt-backport-unlabel-and-clean-labeling branch from 9acb63e to a13ed9a Compare January 4, 2017 20:29
@Fishrock123
Copy link
Contributor Author

@phillipj You're right. I read it wrong. Updated.

phillipj

This comment was marked as off-topic.

@phillipj phillipj merged commit 3f2099d into nodejs:master Jan 5, 2017
phillipj

This comment was marked as off-topic.

Fishrock123 added a commit that referenced this pull request Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

attempt-backport still does not work Edit: now working?!
2 participants