Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt-backport should ignore semver-major changes #105

Open
mscdex opened this issue Dec 14, 2016 · 8 comments
Open

attempt-backport should ignore semver-major changes #105

mscdex opened this issue Dec 14, 2016 · 8 comments

Comments

@mscdex
Copy link
Contributor

mscdex commented Dec 14, 2016

Title says it all, github-bot should not attempt to backport changes marked as semver-major.

/cc @Fishrock123

@Fishrock123
Copy link
Contributor

Should be fairly easy to do, but a lot will slip by because they will be labeled by us later so I'm not 100% sure what to do about that. Have any ideas?

@targos
Copy link
Member

targos commented Dec 14, 2016

a lot will slip by because they will be labeled by us later

Yes but at least once the PR is marked semver-major, the bot will stop trying on every push.

@phillipj
Copy link
Member

Maybe remove any previous backporting labels when GitHub emits a labelling event for semver-major being added?

@Fishrock123
Copy link
Contributor

@thealphanerd Think it might work better if we only added these labels once a PR is closed/merged?

@Fishrock123
Copy link
Contributor

That does mean that people won't know if they'll need to adjust it until after though... :/ So IMO would be worse.

@MylesBorins
Copy link
Contributor

MylesBorins commented Dec 15, 2016

I'm ok with this. As long as it is accurate.

edit: still better than nothing

@mscdex
Copy link
Contributor Author

mscdex commented Dec 28, 2016

So does everyone agree that the bot should (at least) not add any backport-related labels if it sees a change in commits and a semver-major is set on the PR?

I'm not sure proactively removing existing backport-related labels would be a good thing, especially if someone intentionally added the label.

@Fishrock123
Copy link
Contributor

@mscdex that is why #104 only removes it if the bot (last?) added it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants