github-bot: config git author name and email #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed for the attempt-backport functionality of the bot since it does some git actions requiring author name and email, such as `git am`. Refs: nodejs#561
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
For the record: @jbergstroem you approving the changes as is, I assume we don't want to require ansible v2.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for the attempt-backport functionality of the bot since it does
some git actions requiring author name and email, such as
git am.Seeing this when running locally:
But as far as I see, manipulating config isn't possible with the git module. Found git_config module tho, if we're fine with requiring ansible v2.1?
Refs: #561