Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set git author for the github-bot #561

Closed
Fishrock123 opened this issue Dec 8, 2016 · 7 comments
Closed

set git author for the github-bot #561

Fishrock123 opened this issue Dec 8, 2016 · 7 comments
Assignees

Comments

@Fishrock123
Copy link
Contributor

See nodejs/github-bot#100

I wasn't able to get it to work by setting it globally, but setting it in the cloned node repo worked.

git config user.name "nodejs-github-bot"
git config user.email "github-bot@nodejs.org"
@phillipj
Copy link
Member

phillipj commented Dec 8, 2016 via email

@Fishrock123
Copy link
Contributor Author

@phillipj Technically it does "commit" stuff -- using git am applies with the user as the commiter.

@phillipj
Copy link
Member

phillipj commented Dec 9, 2016 via email

@Fishrock123
Copy link
Contributor Author

@phillipj Either or should be fine. On-repo might be simpler since I could not get globally to work on that machine.

phillipj added a commit to phillipj/build that referenced this issue Dec 9, 2016
Needed for the attempt-backport functionality of the bot since it does
some git actions requiring author name and email, such as `git am`.

Refs: nodejs#561
@phillipj
Copy link
Member

phillipj commented Dec 9, 2016

Opened a PR fixing this permanently. It seems to have been set correctly on the server tho, I assume someone has logged in and fixed it by hand.

@Fishrock123
Copy link
Contributor Author

Fishrock123 commented Dec 12, 2016

@phillipj (That was me... @rvagg gave me temporary access to sort these things out)

phillipj added a commit that referenced this issue Dec 14, 2016
Needed for the attempt-backport functionality of the bot since it does
some git actions requiring author name and email, such as `git am`.

Refs: #561
PR-URL: #567
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@phillipj
Copy link
Member

Fixed in 857f590

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants