-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set git author for the github-bot #561
Comments
I'll take a look asap. Any idea why author needs be set when the bot
doesn't try to commit anything?
…On Thu, 8 Dec 2016 at 20:44, Jeremiah Senkpiel ***@***.***> wrote:
See nodejs/github-bot#100
<nodejs/github-bot#100>
I wasn't able to get it to work by setting it globally, but setting it in
the cloned node repo worked.
git config user.name "nodejs-github-bot"
git config user.email ***@***.***"
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#561>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABLLE1-O7nDFsKNgzRizvs-MNWQYWIDYks5rGF4RgaJpZM4LINRj>
.
|
@phillipj Technically it does "commit" stuff -- using |
Ah right! I'll try to get it done tonight. Setting that config locally to
that repo rather than global seems fine to you @Fishrock123?
…On Fri, 9 Dec 2016 at 15:52, Jeremiah Senkpiel ***@***.***> wrote:
@phillipj <https://github.com/phillipj> Technically it does "commit"
stuff -- using git am applies with the user as the commiter.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#561 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABLLE0xWPM4GcUO-crOpfCk_e466mDR9ks5rGWs4gaJpZM4LINRj>
.
|
@phillipj Either or should be fine. On-repo might be simpler since I could not get globally to work on that machine. |
phillipj
added a commit
to phillipj/build
that referenced
this issue
Dec 9, 2016
Needed for the attempt-backport functionality of the bot since it does some git actions requiring author name and email, such as `git am`. Refs: nodejs#561
Opened a PR fixing this permanently. It seems to have been set correctly on the server tho, I assume someone has logged in and fixed it by hand. |
Fixed in 857f590 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See nodejs/github-bot#100
I wasn't able to get it to work by setting it globally, but setting it in the cloned node repo worked.
The text was updated successfully, but these errors were encountered: