-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add RequestedAuthnContext Comparison Type parameter #360
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm interested in merging this PR with refinements:
- Document all the supported values
- Validate that only "exact", "better", "minimum" and "maximum" are accepted
- Include automate test coverage to illustrate it works as expected. You can refactor related code to make it easier to unit-test this if needed.
- When done, rebase and squash the work into a single commit.
I reviewed the spec and found this feature and the supported value documented here confirming that this chang e would improve our spec compliance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm interested in merging this PR with refinements:
- Document all the supported values
- Validate that only "exact", "better", "minimum" and "maximum" are accepted
- Include automate test coverage to illustrate it works as expected. You can refactor related code to make it easier to unit-test this if needed.
- When done, rebase and squash the work into a single commit.
I reviewed the spec and found this feature and the supported value documented here confirming that this chang e would improve our spec compliance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm interested in merging this PR with refinements:
- Document all the supported values
- Validate that only "exact", "better", "minimum" and "maximum" are accepted
- Include automate test coverage to illustrate it works as expected. You can refactor related code to make it easier to unit-test this if needed.
- When done, rebase and squash the work into a single commit.
I reviewed the spec and found this feature and the supported value documented here confirming that this chang e would improve our spec compliance.
test: add test for check the option comparisonType
d141ba8
to
6aee893
Compare
The modifications have been made |
I've merged this, but renamed |
No description provided.