test: add test for check the option comparisonType

node-saml · Mar 19, 2019 · d141ba8 · d141ba8
1 parent cd80c99
commit d141ba8
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 2 deletions.
diff --git a/lib/passport-saml/saml.js b/lib/passport-saml/saml.js
@@ -80,8 +80,14 @@ SAML.prototype.initialize = function (options) {
     options.signatureAlgorithm = 'sha1';
   }
 
-  // better, exact, minimum, maximum
-  if (!options.comparisonType){
+  /**
+   * List of possible values:
+   * - exact : Assertion context must exactly match a context in the list
+   * - minimum:  Assertion context must be at least as strong as a context in the list
+   * - maximum:  Assertion context must be no stronger than a context in the list
+   * - better:  Assertion context must be stronger than all contexts in the list
+   */
+  if (!options.comparisonType || ['exact','minimum','maximum','better'].indexOf(options.comparisonType) === -1){
     options.comparisonType = 'exact';
   }
 

diff --git a/test/tests.js b/test/tests.js