Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new tide API for pyschism #160

Merged
merged 9 commits into from
Oct 23, 2023
Merged

Use new tide API for pyschism #160

merged 9 commits into from
Oct 23, 2023

Conversation

SorooshMani-NOAA
Copy link
Collaborator

@SorooshMani-NOAA SorooshMani-NOAA commented Oct 20, 2023

Pending schism-dev/pyschism#105 for tests to be successful.
schism-dev/pyschism#107 is also good enough for now!

@SorooshMani-NOAA SorooshMani-NOAA self-assigned this Oct 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2023

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 64.84%. Comparing base (1cc7c12) to head (a3fde0e).
Report is 36 commits behind head on main.

Files Patch % Lines
coupledmodeldriver/generate/schism/base.py 50.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #160   +/-   ##
=======================================
  Coverage   64.84%   64.84%           
=======================================
  Files          35       35           
  Lines        3871     3869    -2     
=======================================
- Hits         2510     2509    -1     
+ Misses       1361     1360    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SorooshMani-NOAA SorooshMani-NOAA merged commit 9f835a1 into main Oct 23, 2023
11 checks passed
@SorooshMani-NOAA SorooshMani-NOAA linked an issue Oct 23, 2023 that may be closed by this pull request
@SorooshMani-NOAA SorooshMani-NOAA deleted the depend/pyschism branch October 23, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to use latest pyschism API
2 participants