Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ubuntu-latest image to run Valgrind #4575

Merged
merged 4 commits into from
Dec 29, 2024
Merged

Use ubuntu-latest image to run Valgrind #4575

merged 4 commits into from
Dec 29, 2024

Conversation

nlohmann
Copy link
Owner

@nlohmann nlohmann commented Dec 29, 2024

Install Valgrind on the ubuntu-latest image to use a more version (3.18.1 vs. 3.15.0).

@coveralls
Copy link

coveralls commented Dec 29, 2024

Coverage Status

coverage: 99.639%. remained the same
when pulling 4ed9d12 on valgrind
into 69c8758 on develop.

@nlohmann nlohmann changed the title Use Clang image to run Valgrind Use ubuntu-latest image to run Valgrind Dec 29, 2024
@nlohmann nlohmann added the review needed It would be great if someone could review the proposed changes. label Dec 29, 2024
@nlohmann nlohmann added this to the Release 3.11.4 milestone Dec 29, 2024
@nlohmann nlohmann merged commit 8314ac2 into develop Dec 29, 2024
122 checks passed
@nlohmann nlohmann deleted the valgrind branch December 29, 2024 14:49
nlohmann added a commit that referenced this pull request Dec 29, 2024
* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* Use ubuntu-latest image to run Valgrind (#4575)

* 🔧 use Clang image to run valgrind

* 🔧 use Clang image to run valgrind

* 🔧 use Clang image to run valgrind

* 🔧 use Ubuntu image to run valgrind

* Use Clang image to run iwyu (#4574)

* 🔧 use Clang image to run iwyu

* 🔧 use Clang image to run iwyu

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🎨 format code

* 🔨 clean up
slowriot pushed a commit to slowriot/json that referenced this pull request Jan 10, 2025
* 🔧 use Clang image to run valgrind

* 🔧 use Clang image to run valgrind

* 🔧 use Clang image to run valgrind

* 🔧 use Ubuntu image to run valgrind
slowriot pushed a commit to slowriot/json that referenced this pull request Jan 10, 2025
* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* Use ubuntu-latest image to run Valgrind (nlohmann#4575)

* 🔧 use Clang image to run valgrind

* 🔧 use Clang image to run valgrind

* 🔧 use Clang image to run valgrind

* 🔧 use Ubuntu image to run valgrind

* Use Clang image to run iwyu (nlohmann#4574)

* 🔧 use Clang image to run iwyu

* 🔧 use Clang image to run iwyu

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🎨 format code

* 🔨 clean up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI review needed It would be great if someone could review the proposed changes. S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants