Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwork astyle call #4573

Merged
merged 27 commits into from
Dec 29, 2024
Merged

Overwork astyle call #4573

merged 27 commits into from
Dec 29, 2024

Conversation

nlohmann
Copy link
Owner

@nlohmann nlohmann commented Dec 28, 2024

  • move astyle arguments to separate project file tools/astyle/.astylerc
  • use Python package astyle to install a fixed version of astyle
  • update used astyle version from 3.1 to 3.4.13
  • remove .clang-format file after Use Clang-Format #4226 experiment is cancelled

@coveralls
Copy link

coveralls commented Dec 28, 2024

Coverage Status

coverage: 99.639%. remained the same
when pulling 5f7c9ad on astyle
into 69c8758 on develop.

@github-actions github-actions bot added the CMake label Dec 28, 2024

This comment was marked as outdated.

This comment was marked as outdated.

@nlohmann nlohmann added the review needed It would be great if someone could review the proposed changes. label Dec 29, 2024
* 🔧 use Clang image to run valgrind

* 🔧 use Clang image to run valgrind

* 🔧 use Clang image to run valgrind

* 🔧 use Ubuntu image to run valgrind
* 🔧 use Clang image to run iwyu

* 🔧 use Clang image to run iwyu
@nlohmann nlohmann added this to the Release 3.11.4 milestone Dec 29, 2024
@nlohmann nlohmann merged commit 6057b31 into develop Dec 29, 2024
122 checks passed
@nlohmann nlohmann deleted the astyle branch December 29, 2024 16:06
slowriot pushed a commit to slowriot/json that referenced this pull request Jan 10, 2025
* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* Use ubuntu-latest image to run Valgrind (nlohmann#4575)

* 🔧 use Clang image to run valgrind

* 🔧 use Clang image to run valgrind

* 🔧 use Clang image to run valgrind

* 🔧 use Ubuntu image to run valgrind

* Use Clang image to run iwyu (nlohmann#4574)

* 🔧 use Clang image to run iwyu

* 🔧 use Clang image to run iwyu

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🔧 overwork astyle call

* 🎨 format code

* 🔨 clean up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CMake documentation L review needed It would be great if someone could review the proposed changes. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants