Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Enhanced AsyncStreamCDC #32

Merged
merged 4 commits into from
Jul 15, 2023
Merged

feat!: Enhanced AsyncStreamCDC #32

merged 4 commits into from
Jul 15, 2023

Conversation

cdata
Copy link
Contributor

@cdata cdata commented Jul 13, 2023

  • Support both tokio and futures via feature flags
  • Add documentation and usage examples for AsyncStreamCDC
  • Add tests that specifically target AsyncStreamCDC
  • Run both tokio and futures-based tests in CI

Fixes #31

- Support both `tokio` and `futures` via feature flags
- Add documentation and usage examples for `AsyncStreamCDC`
- Add tests that specifically target `AsyncStreamCDC`
- Run both `tokio` and `futures`-based tests in CI
@nlfiedler
Copy link
Owner

@cdata The automated tests are failing, do I need to make a change in the configuration?

@nlfiedler nlfiedler merged commit 03b5dc3 into nlfiedler:master Jul 15, 2023
@nlfiedler
Copy link
Owner

Excellent, thank you, I'll test and build locally and push out a release.

@nlfiedler
Copy link
Owner

Just to confirm before I update the changelog, this is not a major change, nor is there a breaking change, correct? From my reading of https://doc.rust-lang.org/cargo/reference/semver.html it looks like a minor change. While the AsyncStreamCDC was modified, it was not in a published release. Was there something else I failed to notice that warrants either a BREAKING CHANGE or a major version bump?

Thanks

@cdata
Copy link
Contributor Author

cdata commented Jul 15, 2023

@nlfiedler ah, this was my mistake. I did in fact break AsyncStreamCDC but you are correct to point out that it had never been released in the first place. So, as far as releases are concerned, there was no breaking change here.

@nlfiedler
Copy link
Owner

Very good, it has been released. Thank you again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test, example, API docs for AsyncStreamCDC
2 participants