-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test, example, API docs for AsyncStreamCDC #31
Comments
Heya, I just noticed this ready-to-go One observation I have is that there is a compatibility shim available for A separate but related observation is that Tokio implementations are trending in popularity, so it may make for a better default choice compared to Futures. I would be willing to take a stab at writing some tests and documentation if you would consider compatibility via |
Using |
I took a stab at it. I endedup including support for both |
I agree that pulling in other dependencies should be opt-in since this crate is still pretty small. |
I updated the change to fix the doc example and also make async streaming opt-in. |
The newly introduced
AsyncStreamCDC
needs unit tests, API documentation, and a working example. The first question is how to supply an appropriateAsyncRead
to the chunker since tokio is not compatible.The text was updated successfully, but these errors were encountered: