Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the release procedure #860

Merged
merged 1 commit into from
Mar 21, 2018
Merged

Update the release procedure #860

merged 1 commit into from
Mar 21, 2018

Conversation

Susurrus
Copy link
Contributor

Be more explicit about the development version to specify after doing a release.

cc @nox

Closes #468

[skip ci] Update the release procedure
f8eec17 
Don't change the version in `Cargo.toml` after publishing to crates.io
as it's unnecessary extra manual work.
@Susurrus Susurrus mentioned this pull request Feb 19, 2018
Closed
asomers
asomers approved these changes Feb 27, 2018
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok. But are you also intending to update the instructions to make use of cargo-release?

@asomers
Copy link
Member

asomers commented Mar 5, 2018

I discovered that cargo-release can actually update the CHANGELOG for us. It can't change the libc dependency, though. See https://github.com/sunng87/cargo-release#maintaining-changelog .

@asomers
Copy link
Member

asomers commented Mar 21, 2018

I'm going to merge this, then add cargo-release instructions in a separate PR.

bors r+

bors bot added a commit that referenced this pull request Mar 21, 2018
@bors
Merge #860
fdc5b83 
860: Update the release procedure r=asomers a=Susurrus

Be more explicit about the development version to specify after doing a release.

cc @nox

Closes #468
@bors
Copy link
Contributor

bors bot commented Mar 21, 2018

Build succeeded

@bors bors bot merged commit f8eec17 into nix-rust:master Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Susurrus @asomers