Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's get rid of the -pre suffix. #468

Closed
fiveop opened this issue Nov 15, 2016 · 7 comments
Closed

Let's get rid of the -pre suffix. #468

fiveop opened this issue Nov 15, 2016 · 7 comments
Assignees
Milestone

Comments

@fiveop
Copy link
Contributor

fiveop commented Nov 15, 2016

As @nox stated in #363, no one else does it, and it apparently might cause, problems I don't fully understand, yet. Since, I don't see an advantage in having the pre in the repository all the time, I don't mind.

In addition, I would like to fix the next version to currently 0.(prev + 1).0 and not 0.prev.1, if we ever want to release a hotfix, we can do so in a separate branch with a 0.current.1 version.

I'll prepare an RFC, when I have time.

@fiveop fiveop self-assigned this Nov 15, 2016
@posborne
Copy link
Member

I agree that dropping the pre should be fine within the context of the Rust/Cargo. If user's are using a pre-release version they are pointing to git and Cargo.lock will be dealing with things appropriately.

@Susurrus
Copy link
Contributor

Susurrus commented Jun 4, 2017

I'd actually propose closing this and instead using cargo-publish to automate most of the process. It defaults to -pre for the next version, but I don't really think that's much of a problem. I use it for a couple of my crates and I expect it to garner widespread use among the Rust community and then it'll be less weird.

@Susurrus Susurrus added this to the 1.0 milestone Nov 5, 2017
@nox
Copy link
Contributor

nox commented Feb 19, 2018

@Susurrus Well that cargo-publish behaviour doesn't seem to be the one that most projects follow, so it may be a bad default on its part.

@nox
Copy link
Contributor

nox commented Feb 19, 2018

Actually I'm confused… What do you mean by cargo-publish defaulting to -pre for the next version?

@Susurrus
Copy link
Contributor

Sorry, I meant to indicate cargo-release as the tool that does this. And I believe you can configure the suffix, though I don't believe this is worth changing. There are no known risks of keeping -pre in the version name, as it's been like that for a long time now without issues.

We should clarify this in RELEASE_PROCEDURE.md, however before closing this.

@nox
Copy link
Contributor

nox commented Feb 19, 2018

I wouldn't say "without issues", given there has been at least 2 issues about the release procedure being weird (#363 and this one), and again this is the only crate I know of which does that anyway.

@Susurrus
Copy link
Contributor

I agree that we can remove this step so I filed #860.

bors bot added a commit that referenced this issue Mar 21, 2018
860: Update the release procedure r=asomers a=Susurrus

Be more explicit about the development version to specify after doing a release.

cc @nox

Closes #468
@bors bors bot closed this as completed in #860 Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants