RF: Add sanitized_id field to FieldmapEstimation #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utput entities" This reverts commit a8ccd27.
mgxd
reviewed
Jun 6, 2024
There was a problem hiding this comment.
Looks good - even though testing seems to be broken atm, can you add a small test for this?
TBH, this is a needless headache that is going to invite bugs, and I think we should put a check in the validator warning about B0Field* that contains non-alphanumeric characters, including underscores.
➕
tsalo
approved these changes
Jun 6, 2024
effigies
force-pushed
the
fix/normalize-fmapids
branch
from
743bb1b
to
fb55b65
Compare
|
@mgxd Test failures resolved, new tests added. |
mgxd
approved these changes
Jun 6, 2024
|
WDYT about this being in a patch release vs a feature release? |
|
I'd consider it a patch, since SDCFlows doesn't currently work with what the BIDS spec allows. |
|
I guess this will cause significant cache invalidation (at least in fmriprep) for anyone using a non-sanitized |
|
Okay. We'll just bump to 2.9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #434 along the lines described in #295 (comment).
I think probably the cleanest way forward for downstream is for functions to always store and pass the estimator object, and select
bids_idorsanitized_idonly when a string is needed and what kind of string is needed is known.TBH, this is a needless headache that is going to invite bugs, and I think we should put a check in the validator warning about
B0Field*that contains non-alphanumeric characters, including underscores.