Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add templateflow to DatasetLinks #3267

Merged
merged 4 commits into from
Apr 1, 2024
Merged

Conversation

tsalo
Copy link
Collaborator

@tsalo tsalo commented Apr 1, 2024

References #3261.

Changes proposed in this pull request

  • Add the TemplateFlow base directory to the DatasetLinks.
  • Add the template used for normalization to the Sources for standard-space volumetric outputs.

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 73.84%. Comparing base (123c3f8) to head (ccf7178).

Files Patch % Lines
fmriprep/utils/bids.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3267      +/-   ##
==========================================
- Coverage   73.86%   73.84%   -0.03%     
==========================================
  Files          56       56              
  Lines        4286     4289       +3     
==========================================
+ Hits         3166     3167       +1     
- Misses       1120     1122       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo
Copy link
Collaborator Author

tsalo commented Apr 1, 2024

The Sources from ds054 sub-100185_task-machinegame_run-01_space-MNI152NLin2009cAsym_res-2_desc-preproc_bold.json look good!

  "Sources": [
    "bids:raw:sub-100185/func/sub-100185_task-machinegame_run-01_bold.nii.gz",
    "bids::sub-100185/func/sub-100185_task-machinegame_run-01_from-orig_to-boldref_mode-image_desc-hmc_xfm.txt",
    "bids::sub-100185/func/sub-100185_task-machinegame_run-01_from-boldref_to-auto00000_mode-image_xfm.txt",
    "bids::sub-100185/func/sub-100185_task-machinegame_run-01_from-boldref_to-T1w_mode-image_desc-coreg_xfm.txt",
    "bids:anat:sub-100185/anat/sub-100185_from-T1w_to-MNI152NLin2009cAsym_mode-image_xfm.h5",
    "bids:templateflow:tpl-MNI152NLin2009cAsym/tpl-MNI152NLin2009cAsym_res-02_T1w.nii.gz"
],

EDIT: Also here's the DatasetLinks field from the dataset description:

"DatasetLinks": {
    "raw": "/data",
    "templateflow": "https://github.com/templateflow/templateflow",
    "anat": "/deriv/anat"
}

@tsalo tsalo marked this pull request as ready for review April 1, 2024 17:32
@effigies
Copy link
Member

effigies commented Apr 1, 2024

Let's point the templateflow dataset link at the GitHub repo. A local path is not ideal.

I don't know if it's possible to get a more permanent URL from templateflow itself, e.g., with a commit hash or similar. If it's not easy, let's just open an issue on tf. Might need to wait until versioning templates is sorted out.

@effigies effigies merged commit 1e45712 into nipreps:master Apr 1, 2024
15 of 17 checks passed
@tsalo tsalo deleted the templateflow-links branch April 1, 2024 19:58
effigies added a commit that referenced this pull request Jun 17, 2024
24.0.0 (June 17, 2024)

New feature release in the 24.0.x series.

This release is an incremental improvement on 23.2.x, with some
fixes for bugs discovered in the updated workflow.

New features include separation of HTML reports by session for subjects
with many BOLD runs, a new ``--fs-no-resume`` option to improve interoperability
with less typical FreeSurfer directories, such as those generated by longitudinal
FreeSurfer or FastSurfer, and adoption of DatasetLinks and BIDS-URIs, to follow
the recommendations of recent versions of BIDS.

With thanks to Dimitri Papadopoulos, Basile Pinsard, Celine Provins, Taylor Salo
and Wang Hao-Ting for their contributions!

* FIX: Add "double" type to allowed DisplacementFieldTransform (#3287)
* FIX: Require recent templateflow, select correct aparc dseg.tsv (#3256)
* FIX: Ensure proper templates are retrieved with sloppy (#3251)
* FIX: Delete summary from functional report when separated by sessions (#3223)
* FIX: Support lists in bids filter file containing ``null`` or ``*`` (#3215)
* FIX: Re-enable anat fasttrack for dataset without t1w (#3202)
* ENH: Use BIDSURI in init_ds_boldmask_wf (#3297)
* ENH: Add templateflow to DatasetLinks (#3267)
* ENH: Track proximal sources of functional GIFTIs (#3263)
* ENH: Support named derivative paths (#3264)
* ENH: Track Sources for standard-space outputs (#3262)
* ENH: Add --fs-no-resume option to reuse existing FreeSurfer outputs without resuming (#3142)
* ENH: Use BIDS URIs to track Sources in sidecars (#3255)
* ENH: Ignore unselected subjects in BIDSLayoutIndexer (#3236)
* ENH: Add metadata for motion parameters (#3245)
* ENH: Separate anatomical and functional reports per session for densely sampled dataset (#3191)
* ENH: Leverage T2w if available for BOLD -> anat coregistration (#3208)
* RF: Fix ITK warp conversion to nitransforms format (#3300)
* RF: Load report assembler from nireports (#3177)
* DOC: Clarify ``--dvars-spike-threshold`` uses standardized DVARS (#3205)
* TST: Update test to reflect new report generation behavior (#3210)
* STY: Manual conversions to f-strings (#3241)
* STY: Apply ruff/pyupgrade rule UP031 (#3280)
* STY: Lint and style check full repository (#3221)
* STY: Adopt ruff for linting and formatting (#3206)
* MNT: Pin libitk 5.3 and note dependencies (#3298)
* MNT: Upgrade ruff pre-commit, add fixing checks (#3283)
* MNT: Complete transition from flake8/black to ruff (#3279)
* MNT: Apply Repo-Review suggestions (#3194)
* MNT: Verbatim copy of Apache license 2.0 (#3259)
* MNT: Bump cryptography from 41.0.7 to 42.0.4 (#3234)
* MNT: Drop copyright year, unused dunder fields (#3247)
* MNT: Update environment pins (#3226)
* MNT: Bump codecov/codecov-action from 3 to 4 (#3219)
* DOCKER: Restore mincinfo binary (#3249)
* CI: Move to new circle machine tags (#3248)
* CI: Avoid ruff warning (#3244)
* CI: Pass ruff tests (#3243)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants