Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Add datasink fill-in step to resampling level #3254

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

tsalo
Copy link
Collaborator

@tsalo tsalo commented Mar 11, 2024

Closes #3253.

Changes proposed in this pull request

  • Copy code used to fill in source_file and base_directory fields for reportlet datasinks in init_bold_wf for the full level to the resampling level as well.
    • AFAICT, the only reportlets that should be generated by the resampling level are ds_report_t2scomp and ds_report_t2star_hist, so I could directly add these fields to those nodes, but this approach seems more robust.

Documentation that should be reviewed

None

@tsalo tsalo changed the title Add datasink fill-in step to resampling level FIX: Add datasink fill-in step to resampling level Mar 11, 2024
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.37%. Comparing base (e9b0840) to head (487ee19).

Additional details and impacted files
@@               Coverage Diff                @@
##           maint/23.2.x    #3254      +/-   ##
================================================
+ Coverage         72.34%   72.37%   +0.02%     
================================================
  Files                55       55              
  Lines              4104     4108       +4     
================================================
+ Hits               2969     2973       +4     
  Misses             1135     1135              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies merged commit d8ab59b into nipreps:maint/23.2.x Mar 11, 2024
12 checks passed
@tsalo tsalo deleted the fix-resampling-23 branch March 11, 2024 15:44
effigies added a commit that referenced this pull request May 6, 2024
23.2.2 (May 06, 2024)

Bug fix release in the 23.2.x series.

Fixes an issue with broken connections, which only affects ``--level resampling``.

* FIX: Add datasink fill-in step to resampling level (#3254)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants