Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: load reportlets interfaces from nireports rather than niworkflows #3176

Merged
merged 3 commits into from
Dec 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fmriprep/interfaces/confounds.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@
traits,
)
from nipype.utils.filemanip import fname_presuffix
from nireports.reportlets.modality.func import fMRIPlot
from niworkflows.utils.timeseries import _cifti_timeseries, _nifti_timeseries
from niworkflows.viz.plots import fMRIPlot

LOGGER = logging.getLogger('nipype.interface')

Expand Down
2 changes: 1 addition & 1 deletion fmriprep/interfaces/reports.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
isdefined,
traits,
)
from niworkflows.interfaces.reportlets import base as nrb
from nireports.interfaces.reporting import base as nrb
from smriprep.interfaces.freesurfer import ReconAll

LOGGER = logging.getLogger('nipype.interface')
Expand Down
8 changes: 4 additions & 4 deletions fmriprep/workflows/bold/confounds.py
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,10 @@ def init_bold_confs_wf(
Mask of brain edge voxels

"""
from nireports.interfaces.nuisance import (
CompCorVariancePlot,
ConfoundsCorrelationPlot,
)
from niworkflows.engine.workflows import LiterateWorkflow as Workflow
from niworkflows.interfaces.confounds import ExpandModel, SpikeRegressors
from niworkflows.interfaces.fixes import FixHeaderApplyTransforms as ApplyTransforms
Expand All @@ -154,10 +158,6 @@ def init_bold_confs_wf(
from niworkflows.interfaces.nibabel import ApplyMask, Binarize
from niworkflows.interfaces.patches import RobustACompCor as ACompCor
from niworkflows.interfaces.patches import RobustTCompCor as TCompCor
from niworkflows.interfaces.plotting import (
CompCorVariancePlot,
ConfoundsCorrelationPlot,
)
from niworkflows.interfaces.reportlets.masks import ROIsPlot
from niworkflows.interfaces.utility import TSV2JSON, AddTSVHeader, DictMerge

Expand Down
1 change: 0 additions & 1 deletion fmriprep/workflows/bold/fit.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
from niworkflows.interfaces.header import ValidateImage
from niworkflows.interfaces.nitransforms import ConcatenateXFMs
from niworkflows.interfaces.utility import KeySelect
from niworkflows.utils.connections import listify
from sdcflows.workflows.apply.correction import init_unwarp_wf
from sdcflows.workflows.apply.registration import init_coeff2epi_wf

Expand Down
2 changes: 1 addition & 1 deletion fmriprep/workflows/bold/outputs.py
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ def init_func_fit_reports_wf(
Template space and specifications
"""
from niworkflows.interfaces.reportlets.registration import (
from nireports.interfaces.reporting.base import (
SimpleBeforeAfterRPT as SimpleBeforeAfter,
)
from sdcflows.interfaces.reportlets import FieldmapReportlet
Expand Down
4 changes: 2 additions & 2 deletions fmriprep/workflows/bold/t2s.py
Original file line number Diff line number Diff line change
Expand Up @@ -168,10 +168,10 @@ def init_t2s_reporting_wf(name: str = 't2s_reporting_wf'):
a before/after figure comparing the reference BOLD image and T2\* map
"""
from nipype.pipeline import engine as pe
from niworkflows.interfaces.fixes import FixHeaderApplyTransforms as ApplyTransforms
from niworkflows.interfaces.reportlets.registration import (
from nireports.interfaces.reporting.base import (
SimpleBeforeAfterRPT as SimpleBeforeAfter,
)
from niworkflows.interfaces.fixes import FixHeaderApplyTransforms as ApplyTransforms

workflow = pe.Workflow(name=name)

Expand Down