Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Unprotected import of sentry_sdk, which is not a dependency #2460

Merged
merged 1 commit into from
Jul 19, 2021
Merged

FIX: Unprotected import of sentry_sdk, which is not a dependency #2460

merged 1 commit into from
Jul 19, 2021

Conversation

oesteban
Copy link
Member

Resolves: #2411.

Changes proposed in this pull request

Documentation that should be reviewed

@oesteban oesteban requested a review from effigies July 19, 2021 13:55
@oesteban
Copy link
Member Author

Tested locally on an environment without sentry. Current maint/20.2.x crashed as expected and this patch worked as expected.

@oesteban oesteban merged commit 0d55621 into nipreps:maint/20.2.x Jul 19, 2021
@oesteban oesteban deleted the fix/2411 branch July 19, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@effigies effigies effigies approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oesteban @effigies