Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Specify logger for warning #2298

Merged
merged 1 commit into from
Oct 8, 2020
Merged

FIX: Specify logger for warning #2298

merged 1 commit into from
Oct 8, 2020

Conversation

mgxd
Copy link
Collaborator

@mgxd mgxd commented Oct 6, 2020

Closes #2296

effigies
effigies approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. Looks like this is going to affect all multi-echo datasets, so we'll need to plan a patch release in the very short term.

@mgxd mgxd mentioned this pull request Oct 6, 2020
Closed
@effigies
Copy link
Member

effigies commented Oct 6, 2020

Oh, rereading, it's just single-echo datasets with echo- entities. (I was wondering why ds216 wasn't hitting this.) That's a bit rarer.

Would be good to try to increase coverage for workflow building with synthetic data.

@mgxd mgxd merged commit 0b2cd6f into nipreps:maint/20.2.x Oct 8, 2020
@mgxd mgxd deleted the fix/bold-logging branch October 8, 2020 13:58
@effigies effigies added this to the 20.2.1 milestone Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@effigies effigies effigies approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
20.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@mgxd @effigies