underscores for routine parameters #21192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
|
@metagn Hey, It breaks proc hello[_](x: _) = discarddoesn't compile any more. |
PhilippMDoerner
added a commit
to PhilippMDoerner/norm
that referenced
this pull request
Feb 25, 2023
These are (currently) no longer supported by nim devel. For reference, see: - nim-lang/Nim#21435 - nim-lang/Nim#21192 It is likely that this behaviour will stay. Either way, there is no particular need to stick with [_], thus we shall proactively remove it, just to be safe.
PhilippMDoerner
added a commit
to PhilippMDoerner/Nim
that referenced
this pull request
Feb 26, 2023
As described by nim-lang#21435 , generic proc declarations making use of `_` as generic parameter are no longer possible. This is a change that was introduced by nim-lang#21192 . During the debate over if this should be part of the intended spec in nim-lang#21435 we concluded that it is and thus should be mentioned as a breaking change in the changelogs.
ringabout
pushed a commit
that referenced
this pull request
Feb 26, 2023
…21437) Add mention of breaking change to changelog As described by #21435 , generic proc declarations making use of `_` as generic parameter are no longer possible. This is a change that was introduced by #21192 . During the debate over if this should be part of the intended spec in #21435 we concluded that it is and thus should be mentioned as a breaking change in the changelogs.
survivorm
pushed a commit
to survivorm/Nim
that referenced
this pull request
Feb 28, 2023
* underscores for routine parameters fixes nim-lang#13443, fixes nim-lang#13804, refs nim-lang#21121 * add changelog + more tests * support generics and ensure inferred lambdas work
survivorm
pushed a commit
to survivorm/Nim
that referenced
this pull request
Feb 28, 2023
…im-lang#21437) Add mention of breaking change to changelog As described by nim-lang#21435 , generic proc declarations making use of `_` as generic parameter are no longer possible. This is a change that was introduced by nim-lang#21192 . During the debate over if this should be part of the intended spec in nim-lang#21435 we concluded that it is and thus should be mentioned as a breaking change in the changelogs.
capocasa
pushed a commit
to capocasa/Nim
that referenced
this pull request
Mar 31, 2023
* underscores for routine parameters fixes nim-lang#13443, fixes nim-lang#13804, refs nim-lang#21121 * add changelog + more tests * support generics and ensure inferred lambdas work
capocasa
pushed a commit
to capocasa/Nim
that referenced
this pull request
Mar 31, 2023
…im-lang#21437) Add mention of breaking change to changelog As described by nim-lang#21435 , generic proc declarations making use of `_` as generic parameter are no longer possible. This is a change that was introduced by nim-lang#21192 . During the debate over if this should be part of the intended spec in nim-lang#21435 we concluded that it is and thus should be mentioned as a breaking change in the changelogs.
bung87
pushed a commit
to bung87/Nim
that referenced
this pull request
Jul 29, 2023
* underscores for routine parameters fixes nim-lang#13443, fixes nim-lang#13804, refs nim-lang#21121 * add changelog + more tests * support generics and ensure inferred lambdas work
bung87
pushed a commit
to bung87/Nim
that referenced
this pull request
Jul 29, 2023
…im-lang#21437) Add mention of breaking change to changelog As described by nim-lang#21435 , generic proc declarations making use of `_` as generic parameter are no longer possible. This is a change that was introduced by nim-lang#21192 . During the debate over if this should be part of the intended spec in nim-lang#21435 we concluded that it is and thus should be mentioned as a breaking change in the changelogs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #13443, fixes #13804, refs #21121
This is #17581 but with support for templates and generic procs. The implementation works now due to #21121.
Would document, but that would be best alongside a full PR for #20687.
Failing package is weave: mratsim/weave#190(merged)