Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #21116; always mangles the param #21121

Merged
merged 4 commits into from
Dec 17, 2022
Merged

fixes #21116; always mangles the param #21121

merged 4 commits into from
Dec 17, 2022

Conversation

ringabout
Copy link
Member

@ringabout ringabout commented Dec 16, 2022

fixes #21116

N_LIB_PRIVATE N_NIMCALL(void, p__test55_2)(NimStringV2 glob__icdZQ89bZ6Q81ZmV9cDcnAEQ);

Or something simpler?

@ringabout ringabout closed this Dec 16, 2022
@ringabout ringabout reopened this Dec 16, 2022
tests/ccgbugs/t21116.nim Outdated Show resolved Hide resolved
@Araq Araq merged commit d83f66a into devel Dec 17, 2022
@Araq Araq deleted the pr_egg branch December 17, 2022 08:10
@github-actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from d83f66a

Hint: mm: orc; opt: speed; options: -d:release
165591 lines; 8.245s; 611.91MiB peakmem

metagn added a commit to metagn/Nim that referenced this pull request Dec 28, 2022
Araq pushed a commit that referenced this pull request Jan 8, 2023
* underscores for routine parameters

fixes #13443, fixes #13804, refs #21121

* add changelog + more tests

* support generics and ensure inferred lambdas work
pmp-p added a commit to pmp-p/nim-panda3d-wasm that referenced this pull request Jan 20, 2023
survivorm pushed a commit to survivorm/Nim that referenced this pull request Feb 28, 2023
* fixes nim-lang#21116; always mangles the param

* idOrSig

* fixes tests

* Apply suggestions from code review
survivorm pushed a commit to survivorm/Nim that referenced this pull request Feb 28, 2023
* underscores for routine parameters

fixes nim-lang#13443, fixes nim-lang#13804, refs nim-lang#21121

* add changelog + more tests

* support generics and ensure inferred lambdas work
capocasa pushed a commit to capocasa/Nim that referenced this pull request Mar 31, 2023
* fixes nim-lang#21116; always mangles the param

* idOrSig

* fixes tests

* Apply suggestions from code review
capocasa pushed a commit to capocasa/Nim that referenced this pull request Mar 31, 2023
* underscores for routine parameters

fixes nim-lang#13443, fixes nim-lang#13804, refs nim-lang#21121

* add changelog + more tests

* support generics and ensure inferred lambdas work
bung87 pushed a commit to bung87/Nim that referenced this pull request Jul 29, 2023
* fixes nim-lang#21116; always mangles the param

* idOrSig

* fixes tests

* Apply suggestions from code review
bung87 pushed a commit to bung87/Nim that referenced this pull request Jul 29, 2023
* underscores for routine parameters

fixes nim-lang#13443, fixes nim-lang#13804, refs nim-lang#21121

* add changelog + more tests

* support generics and ensure inferred lambdas work
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

os.walkDir breaks if called in a function with a parameter named 'glob'
2 participants