Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support full list of GitHub keywords #73

Merged
merged 3 commits into from
Oct 17, 2019
Merged

Support full list of GitHub keywords #73

merged 3 commits into from
Oct 17, 2019

Conversation

mjcarroll
Copy link
Contributor

@mjcarroll mjcarroll commented Oct 17, 2019 •
edited
Loading

Closes #71

@mjcarroll
Copy link
Contributor Author

As an additional question here, should this support the keywords with a colon? For examples Fixes: #71 vs Fixes #71. It does not appear that it currently supports this capability.

@mjcarroll mjcarroll force-pushed the support_github_keywords branch from 2ee2ef7 to d72b653 Compare October 17, 2019 18:11
@nikku
Copy link
Owner

nikku commented Oct 17, 2019

As an additional question here, should this support the keywords with a colon? For examples Fixes: #71 vs Fixes #71. It does not appear that it currently supports this capability.

What's your thought? I personally find it odd to use colons here but I see people doing it. So why not support / recognize that one, too.

@mjcarroll
Copy link
Contributor Author

I think since Github supports it, it probably makes sense to support here as well.

@mjcarroll
Copy link
Contributor Author

Added support for the colon. Feedback welcome. I originally attempted doing the close|closes|closed match with another group like (close(s|d)?) but it makes the match extraction logic break below, so simple seemed better.

If there are tests somewhere else that need to be updated, let me know, this seemed to be the right location.

mjcarroll and others added 3 commits October 17, 2019 23:00
@mjcarroll @nikku
feat(app): recognize full list of GitHub keywords in links
c49400e 
Closes nikku#71

Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll @nikku
feat(app): recognize colon-separation in links
6c9a9a8 
Related to nikku#71

Signed-off-by: Michael Carroll <michael@openrobotics.org>
@nikku
style(app): correct spec spacing
3e93c50
@nikku nikku force-pushed the support_github_keywords branch from 324dbb8 to 3e93c50 Compare October 17, 2019 21:02
@nikku nikku self-requested a review October 17, 2019 21:03
nikku
nikku approved these changes Oct 17, 2019
View reviewed changes
Copy link
Owner

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks for your contribution.

@nikku nikku merged commit c98be69 into nikku:master Oct 17, 2019
@mjcarroll mjcarroll mentioned this pull request Oct 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikku nikku nikku approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support github's full array of closing keywords
2 participants
@mjcarroll @nikku