Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support github's full array of closing keywords #71

Closed
jjlankinen opened this issue Oct 17, 2019 · 5 comments · Fixed by #73
Closed

Support github's full array of closing keywords #71

jjlankinen opened this issue Oct 17, 2019 · 5 comments · Fixed by #73
Labels
enhancement New feature or request

Comments

@jjlankinen
Copy link

Is your feature request related to a problem? Please describe.

Currently Wuffle board only supports 2 Github's closing keywords which are closes and fixes and it would be nice to actually get this board to integrate into the Github better by adding support for the rest of the keywords also.

Describe the solution you'd like

I would like to see every Github's closing keywords supported which are described here: https://help.github.com/en/articles/closing-issues-using-keywords

  • close
  • closes
  • closed
  • fix
  • fixes
  • fixed
  • resolve
  • resolves
  • resolved

Describe alternatives you've considered

If this is too much of work and it's decided not to follow full keyword support then alternative is to force team members and collaborators to suck it up and force them to change their keyword usage habits which can be a bit problematic as unknown collaborators need to know which keywords can be used.

@nikku nikku added the enhancement New feature or request label Oct 17, 2019
@nikku
Copy link
Owner

nikku commented Oct 17, 2019

I'm fine supporting the full range of closing keywords. 👍

@mjcarroll
Copy link
Contributor

Waffle also support connects to and connected to for a parent-child relationship.

@jjlankinen: I believe the place to update for all of those would be here: https://github.com/mjcarroll/wuffle/blob/0ed57f7202a25d47df3a50b3788142d7fb65f2cb/packages/app/lib/util/links.js#L8

@nikku
Copy link
Owner

nikku commented Oct 17, 2019

I personally don't like the connects and connected to it is highly ambiguous.

For the closes hints, I'm happy to accept a PR that contributes the improvements.

mjcarroll added a commit to mjcarroll/wuffle that referenced this issue Oct 17, 2019
Closes nikku#71

Signed-off-by: Michael Carroll <michael@openrobotics.org>
mjcarroll added a commit to mjcarroll/wuffle that referenced this issue Oct 17, 2019
Closes nikku#71

Signed-off-by: Michael Carroll <michael@openrobotics.org>
@nikku
Copy link
Owner

nikku commented Oct 17, 2019

Waffle also support connects to and connected to for a parent-child relationship.

I reconsidered my opinion here. The keywords are cryptic enough so that they probably do not cause confusion. Likely no-one except for a former Waffle user are using these. If they matter to you, file a PR and I'll accept it as a contribution.

nikku pushed a commit to mjcarroll/wuffle that referenced this issue Oct 17, 2019
Closes nikku#71

Signed-off-by: Michael Carroll <michael@openrobotics.org>
nikku pushed a commit to mjcarroll/wuffle that referenced this issue Oct 17, 2019
Related to nikku#71

Signed-off-by: Michael Carroll <michael@openrobotics.org>
@nikku nikku closed this as completed in #73 Oct 17, 2019
nikku pushed a commit that referenced this issue Oct 17, 2019
Closes #71

Signed-off-by: Michael Carroll <michael@openrobotics.org>
nikku pushed a commit that referenced this issue Oct 17, 2019
Related to #71

Signed-off-by: Michael Carroll <michael@openrobotics.org>
@nikku
Copy link
Owner

nikku commented Oct 17, 2019

Released with v0.28.0. Special thanks to @mjcarroll for contributing this improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants