-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support github's full array of closing keywords #71
Comments
I'm fine supporting the full range of closing keywords. 👍 |
Waffle also support @jjlankinen: I believe the place to update for all of those would be here: https://github.com/mjcarroll/wuffle/blob/0ed57f7202a25d47df3a50b3788142d7fb65f2cb/packages/app/lib/util/links.js#L8 |
I personally don't like the For the closes hints, I'm happy to accept a PR that contributes the improvements. |
Closes nikku#71 Signed-off-by: Michael Carroll <michael@openrobotics.org>
Closes nikku#71 Signed-off-by: Michael Carroll <michael@openrobotics.org>
I reconsidered my opinion here. The keywords are cryptic enough so that they probably do not cause confusion. Likely no-one except for a former Waffle user are using these. If they matter to you, file a PR and I'll accept it as a contribution. |
Closes nikku#71 Signed-off-by: Michael Carroll <michael@openrobotics.org>
Related to nikku#71 Signed-off-by: Michael Carroll <michael@openrobotics.org>
Closes #71 Signed-off-by: Michael Carroll <michael@openrobotics.org>
Related to #71 Signed-off-by: Michael Carroll <michael@openrobotics.org>
Released with |
Is your feature request related to a problem? Please describe.
Currently Wuffle board only supports 2 Github's closing keywords which are closes and fixes and it would be nice to actually get this board to integrate into the Github better by adding support for the rest of the keywords also.
Describe the solution you'd like
I would like to see every Github's closing keywords supported which are described here: https://help.github.com/en/articles/closing-issues-using-keywords
Describe alternatives you've considered
If this is too much of work and it's decided not to follow full keyword support then alternative is to force team members and collaborators to suck it up and force them to change their keyword usage habits which can be a bit problematic as unknown collaborators need to know which keywords can be used.
The text was updated successfully, but these errors were encountered: