Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

Fix/german slot matching #179

Merged
merged 11 commits into from
Feb 21, 2022
Merged

Fix/german slot matching #179

merged 11 commits into from
Feb 21, 2022

Conversation

nielsmaerten
Copy link
Owner

@nielsmaerten nielsmaerten commented Feb 20, 2022

Description

This PR attempts to fix slot filling in German. See #178 for more information on the issue.

How Has This Been Tested?

  • Tested in simulator
  • Tested on a real device

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I've made my changes in a separate branch
  • Translation has been updated to match action definition
  • My change is passing new and existing tests

@nielsmaerten nielsmaerten force-pushed the fix/german-slot-matching branch from 5af4f59 to 2eb340c Compare February 20, 2022 12:05
@codecov
Copy link

codecov bot commented Feb 20, 2022

Codecov Report

Merging #179 (f548174) into main (79c767c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #179   +/-   ##
=======================================
  Coverage   95.27%   95.27%           
=======================================
  Files          52       52           
  Lines         973      973           
  Branches      192      192           
=======================================
  Hits          927      927           
  Misses         45       45           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79c767c...f548174. Read the comment docs.

@nielsmaerten nielsmaerten marked this pull request as ready for review February 21, 2022 19:06
@nielsmaerten nielsmaerten merged commit 3a171be into main Feb 21, 2022
@nielsmaerten nielsmaerten deleted the fix/german-slot-matching branch February 21, 2022 19:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant