This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
Do not merge/fix de slot filling #178
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this configuration, some deep invocations seem to be working. To be tested by alpha testers.
This reverts commit 7033d66.
|
In it's current state (2022-02-19), some deep invocations are working. Namely the example invocations provided in the Action definition for the Documentation page. Deployed this version to alpha channel, and asked Utz to test it on a real device. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge this PR.
It's a WIP trying to figure out how to get the NLN to accept 'deep' invocations in German.
Bug description:
In German, deep invocations always fail. For example, asking Gluco Check to read out (just) glucose fails the 'Slot Filling/Matching' phase in NLN, and then reads out all metrics selected on the user profile.
This PR tries to simplify the possible types (DmMetrics), invocations somewhat, trying to pinpoint the problem.