Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support node v12 #211

Merged
merged 2 commits into from
Jul 2, 2019
Merged

support node v12 #211

merged 2 commits into from
Jul 2, 2019

Commits on Jun 30, 2019

  1. support node v12 

    - upgrade nan to v2.14
- use  Nan::Utf8String rather than v8::String::Utf8Value

Fixes #206
    @nickdesaulniers
    nickdesaulniers committed Jun 30, 2019
    Configuration menu
    Copy the full SHA
    b8fba45 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2019

  1. fix 1 of the 2 Nan::Callback::Call deprecation warnings 

    Looks like the Nan::Callback::Call() API deprecated bare calls that
don't pass a new Nan::AsyncResource().  Luckily, in this case we were
already subclassing Nan::AsyncWorker, which has a member named
`async_resource` so all we have to do is explicitly pass this along.

I wonder if Nan should just do this for me? *hmm*

Bug #209
    @nickdesaulniers
    nickdesaulniers committed Jul 1, 2019
    Configuration menu
    Copy the full SHA
    153f3b8 View commit details
    Browse the repository at this point in the history