support node v12 #211
Merged
support node v12 #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- upgrade nan to v2.14 - use Nan::Utf8String rather than v8::String::Utf8Value Fixes #206
Looks like the Nan::Callback::Call() API deprecated bare calls that don't pass a new Nan::AsyncResource(). Luckily, in this case we were already subclassing Nan::AsyncWorker, which has a member named `async_resource` so all we have to do is explicitly pass this along. I wonder if Nan should just do this for me? *hmm* Bug #209
bnoordhuis
reviewed
Jul 1, 2019
| @@ -5,7 +5,7 @@ | |||
| "main": "lib/index.js", | |||
| "dependencies": { | |||
| "bindings": "1.2.1", | |||
| "nan": "2.8" | |||
| "nan": "2.14.0" | |||
There was a problem hiding this comment.
Is there a reason to depend on a specific nan version instead of ^2.14.0? Nan follows semver, releases are backwards compatible.
There was a problem hiding this comment.
precise versions guarantee what we're getting, but that sounds reasonable for nan, doing ^2.14.0 or 2.14
reqshark
approved these changes
Jul 1, 2019
| @@ -5,7 +5,7 @@ | |||
| "main": "lib/index.js", | |||
| "dependencies": { | |||
| "bindings": "1.2.1", | |||
| "nan": "2.8" | |||
| "nan": "2.14.0" | |||
There was a problem hiding this comment.
precise versions guarantee what we're getting, but that sounds reasonable for nan, doing ^2.14.0 or 2.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #206