Nimble spinner spec #837
Merged
Nimble spinner spec #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msmithNI
requested review from
rajsite,
jattasNI,
fredvisser and
atmgrifter00
as code owners
jattasNI
reviewed
Nov 29, 2022
jattasNI
reviewed
Nov 30, 2022
rajsite
reviewed
Nov 30, 2022
msmithNI
commented
Dec 2, 2022
jattasNI
approved these changes
Dec 2, 2022
rajsite
approved these changes
Dec 2, 2022
atmgrifter00
approved these changes
Dec 12, 2022
msmithNI
added a commit
that referenced
this pull request
Dec 16, 2022
# Pull Request ## 🤨 Rationale Fixes #346 **Note on spinner sizes:** Brandon added [additional sizes in the XD design doc](https://xd.adobe.com/view/33ffad4a-eb2c-4241-b8c5-ebfff1faf6f6-66ac/screen/dece308f-79e7-48ec-ab41-011f3376b49b/specs/). However, after some more discussion we're not adding a `size` attribute with these specific sizes for now, the component will scale to the width/height it's given (via CSS styles). Default is 16x16. The additional sizes are described in Storybook on the Spinner's doc page. See PR discussion/comments for more info. (Angular/Blazor integration will be a followup PR) ## 👩💻 Implementation See [the spec and its PR/discussion](#837) for implementation details. Simple element (no attributes/properties), mostly CSS animations, including a simplified `prefers-reduced-motion` animation. ## 🧪 Testing Tested locally, with + without OS animations (to test prefers-reduced-motion). Added autotests + Storybook stories. ## ✅ Checklist - [ ] I have updated the project documentation to reflect my changes or determined no changes are needed. - Component table will be updated with the next PR (Angular/Blazor integration)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Creating spec for spinner component.
Also see #346
👩💻 Implementation
Based on 'custom component' template. Deriving from the FAST
progress-ringis an option but not currently planned for this spinner (see spec).🧪 Testing
N/A
✅ Checklist