Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spinner design followup (PowerGreen only vs. changeable color) #916

Closed
msmithNI opened this issue Dec 13, 2022 · 3 comments
Closed

Spinner design followup (PowerGreen only vs. changeable color) #916

msmithNI opened this issue Dec 13, 2022 · 3 comments
Assignees

Comments

@msmithNI
Copy link
Contributor

😯 Problem to Solve

Followup from #822 for #346

The XD design for the spinner has a "Color UI Alt" version that makes the spinning bits the PowerGreen color. There's discussion/ an open question in #837 on how we should expose that variant:

  • Have we shipped apps using that color variant already / do we already have specific apps in mind that will use that specific color for a spinner? (Brandon to answer this)
  • Do we instead need a more general way for apps to provide an arbitrary/custom color for the spinner, to match their app theme/ background?
    • Dev note: In this case, we'd make a new token like spinner-color that can be overridden, and follow the same patterns we did for the icon colors which also allow overrides.
@msmithNI msmithNI added enhancement New feature or request triage New issue that needs to be reviewed UX and removed enhancement New feature or request triage New issue that needs to be reviewed labels Dec 13, 2022
@msmithNI msmithNI mentioned this issue Dec 13, 2022
1 task
@NIbokeefe
Copy link

NIbokeefe commented Dec 14, 2022

I'm still looking into where the power-green color scheme has been used.

I created an update to the design spec including additional sizes for the "bits-squares."

Sizes now include:

16, 32, 48, 64, 96, 128

@NIbokeefe
Copy link

We'll move forward without the Powergreen version of the bits spinner. I have not found where it's implemented.

@nate-ni nate-ni moved this from Backlog to Done in Nimble Design System Priorities Jan 5, 2023
@nate-ni
Copy link
Contributor

nate-ni commented Jan 5, 2023

Also, we have returned to the original sizes with 16, 32, 64.

@nate-ni nate-ni closed this as completed Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants