Adding favicon to Storybook #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jattasNI
approved these changes
Sep 1, 2022
rajsite
requested changes
Sep 1, 2022
change/@ni-nimble-components-3b8b48de-f57d-44f1-a1ab-e1321174f1dc.json
Outdated
Show resolved
Hide resolved
rajsite
approved these changes
Sep 2, 2022
Sounds good Co-authored-by: Milan Raj <rajsite@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
The favicon in the Storybook site was non existent. Updating it to the Nimble icon.
Used this information to help direct me to updating it:
How to change favicon? (Storybook GitHub)
Reference example from the MS Fluent Storybook Repo
I think this replaces this closed pull request: #217
👩💻 Implementation
🧪 Testing
Ran storybook locally to make sure it displays the favicon correctly.
✅ Checklist