Add favicon to published Storybook #217
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajsite
reviewed
Dec 6, 2021
| import theme from './theme'; | ||
|
|
||
| const link = document.createElement('link'); |
There was a problem hiding this comment.
Does an approach like this work: storybookjs/storybook#6155 (comment)
Pretty sure the js based approach won't work very generally (search indexing, bookmarks in browsers)
rajsite
reviewed
Dec 8, 2021
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
We should also update the example client app favicon
|
@fredvisser still need the branch? |
nate-ni
added a commit
that referenced
this pull request
Sep 6, 2022
# Pull Request ## 🤨 Rationale The favicon in the Storybook site was non existent. Updating it to the Nimble icon. Used this information to help direct me to updating it: [How to change favicon? (Storybook GitHub)](storybookjs/storybook#6155) [Reference example from the MS Fluent Storybook Repo](https://github.com/microsoft/fluentui/blob/4c970883a796505b132b356aa03302c068eb0ea9/packages/web-components/.storybook/manager-head.html) I think this replaces this closed pull request: #217 ## 👩💻 Implementation - Added ICO and PNG versions of the Nimble Icon - Created an HTML file to reference them as the favicon - Updated the npm command 'storybook' to add the image files directory ## 🧪 Testing Ran storybook locally to make sure it displays the favicon correctly. <img width="871" alt="image" src="https://user-images.githubusercontent.com/109235103/187926080-0cedfec7-ea43-4453-a316-69f36ba0ddbf.png"> <img width="481" alt="image" src="https://user-images.githubusercontent.com/109235103/187926268-c222d54b-1eb6-420c-8d09-b249e8b5f368.png"> ## ✅ Checklist - [x ] I have updated the project documentation to reflect my changes or determined no changes are needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Blocked: I'm going to wait on new icons, before supporting all the browsers in all the ways.
Both local and published versions of Storybook didn't include a custom favicon. While the icon is likely to change in the coming weeks, this PR takes the existing logo and uses it as a favicon.
👩💻 Implementation
Imported and specified the favicon within the existing
.storybook/manager.jsfile.Also, updated the old logo used within the top-level nimble readme.
🧪 Testing
Confirmed the favicon appears correctly in Firefox, Chrome,
Safariwhen hosted locally.✅ Checklist