Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define type for banner toggle event detail #1065

Merged
merged 2 commits into from
Feb 17, 2023
Merged

Define type for banner toggle event detail #1065

merged 2 commits into from
Feb 17, 2023

Conversation

m-akinc
Copy link
Contributor

@m-akinc m-akinc commented Feb 17, 2023

Pull Request

🤨 Rationale

Should define explict type for banner's toggle event details. We want to re-export this from nimble-angular.

👩‍💻 Implementation

Defined new type. Followed example of the menu button's identical event details.

🧪 Testing

None

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@m-akinc m-akinc mentioned this pull request Feb 17, 2023
Merged
1 task
@m-akinc m-akinc merged commit 8c748c8 into main Feb 17, 2023
@m-akinc m-akinc deleted the users/makinc/banner-event-type branch February 17, 2023 21:10
@nate-ni nate-ni mentioned this pull request Feb 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajsite rajsite rajsite approved these changes

@jattasNI jattasNI Awaiting requested review from jattasNI jattasNI is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-akinc @rajsite