-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nimble-banner Component #305
Comments
Related: awaiting some UX input from #724 |
Whether or not the banner is dismissible should be configurable. Potential use-case for a non-dismissible banner from azdo feature 1919090: User sees 401 page when unauthorized to view an application:
|
@nate-ni, your current recommendation is not supporting arbitrary content in the banner, but my initial reaction is that limiting to purely string content is too prohibited. In fact, most of the screenshots you show as examples have additional content. I think a common use case will be putting a link in the banner to get extra help or more information. Therefore, I think we should let clients put more content, such as anchors, within their banner. |
I found one example in SLS where a banner contained a link (source). It would be worth checking with the PM or UX designer for SLE licensing to see if the SLE Licensing feature has a similar requirement. |
It's great to see an example. Translating that to the nimble banner would probably be like: If we provide a version with link or button for the action. |
@mollykreis, thanks for the input. We have added the ability to provide a link or command into the banner. From the visual design, urls will get presented as links and commands will get presented as a button. We'll only support one for now, I believe, but can definitely expand on that in the future if needed. |
## π€¨ Rationale Spec for banner component (see #305) ## π©βπ» Implementation N/A ## π§ͺ Testing N/A ## β Checklist - [x] I have updated the project documentation to reflect my changes or determined no changes are needed. --------- Co-authored-by: mollykreis <20542556+mollykreis@users.noreply.github.com>
# Pull Request ## π€¨ Rationale See #305 ## π©βπ» Implementation - Created new banner component (not based on FAST) - Added unit tests and visual Storybook tests - Updated README ## π§ͺ Testing Unit tests and Storybook testing ## β Checklist - [x] I have updated the project documentation to reflect my changes or determined no changes are needed. --------- Co-authored-by: mollykreis <20542556+mollykreis@users.noreply.github.com>
π©π½βπ€βπ©πΌπ¨π»βπ€βπ¨πΎ Feature Team
Feature Lead: @m-akinc
Feature Tech Lead: @jattasNI
Feature Manager: @fredvisser
Product Manager: @nate-ni
IxD: @leslieab
ViD: @NIbokeefe
π― Problem to Solve
We need a banner to provide information to the user.
For ease of use, the banner should be simply configured without requiring knowledge of the Nimble Design token system or the need to hardcode design information into the instance of the component (colors, sizing, etc.).
This feature is for more persistent/static notifications. There is another component (currently called toast) that would be used for a temporary, overlay style notifications.
π Proposed solution
In scope
Out of scope
Supporting arbitrary content in the banner.
Open questions
Banners references from other Design Systems
https://spectrum.adobe.com/page/alert-banner/
https://carbondesignsystem.com/components/notification/usage/
https://atlassian.design/components/banner/examples
Some examples of banner screenshots
Visual Design
Accessibility Considerations
Consider ARIA live regions for this component
https://web.dev/learn/accessibility/javascript/#page-level-2
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Live_Regions
π Tasks
Related PRs
The text was updated successfully, but these errors were encountered: