Replace landing page image with a newer one #103
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankieroberto
temporarily deployed
to
nhs-prototyp-update-lan-m2xrxf
There was a problem hiding this comment.
Well spotted!
Looks good but the version number seems to be 0.0.0?
I wonder if we should remove the version number from the index page in the kit, to avoid having to keep this screenshot up-to-date? Or maybe manually remove the version number from the page before taking the screenshot, and then if it appears within the page it’s less noticeable? 🤔
|
Ah yes, I made it 0.0.0 on purpose so that it doesn't need updating. Maybe it's more confusing and should just remove it entirely? |
|
@anandamaryon1 yeah, maybe remove it entirely? 🤔 |
|
@anandamaryon1 I have suggested some other content changes to the default page in nhsuk/nhsuk-prototype-kit#423 so maybe hold fire on updating the image for now 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the guide and noticed the image on the
/check-it-workspage is out of date enough that I had to check that it was the right page.This replaces it with a newer image.