Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JAWS and NVDA not detecting heading inside legend #534

Closed
Fenwick17 opened this issue Oct 1, 2019 · 4 comments
Closed

JAWS and NVDA not detecting heading inside legend #534

Fenwick17 opened this issue Oct 1, 2019 · 4 comments
Labels
accessibility Accessibility related 🐛 bug Something isn't working the way it should (including incorrect wording in documentation)

Comments

@Fenwick17
Copy link
Contributor

Bug Report

What is the issue?

When using an <h#> element within the <legend> as per the 'Fieldset as page heading' pattern Jaws and NVDA will not treat this as a heading, therefore it does not display in the list of headings.

What steps are required to reproduce the issue?

Access any page with a <h#> inside a <legend> with Jaws or NVDA

What was the environment where this issue occurred?

  • Device: Laptop
  • Operating System: Windows 10
  • Browser: Chrome
  • Browser version: Latest
  • NHS.UK frontend package version: 2.3.1
@Fenwick17 Fenwick17 added accessibility Accessibility related 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) component awaiting triage Needs triaging by team labels Oct 1, 2019
@Ross-Clark
Copy link
Contributor

I cant replicate this issue with my set up
would like to go through this with you when possible

@NickColley
Copy link

Hey folks,

I think we've been made aware of the same issue and will be tackling this in this issue on GOV.UK Frontend: alphagov/govuk-frontend#1605

@chrimesdev
Copy link
Member

chrimesdev commented Oct 10, 2019

Thanks @NickColley, @Fenwick17 found it to the be the overflow: hidden; on the fieldset which was causing the problem for us (#542).

When Adam was testing this, he also tested GOVUK frontend and found it not to be an issue with the GOVUK fieldset. It looks like this particular fix was made to GOVUK frontend back in September (alphagov/govuk-frontend#1548).

So I'm not sure if this is a different issue but I'll leave this open for discussion and maybe we can help, Adam may be able to add more info.

@chrimesdev
Copy link
Member

We've fixed the original issue raised in release 3.0.0.

Related: alphagov/govuk-frontend#1605 (comment)

I'll close this issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Accessibility related 🐛 bug Something isn't working the way it should (including incorrect wording in documentation)
Projects
None yet
Development

No branches or pull requests

4 participants