Fix fieldset legend text clipping when using a custom or fallback font #1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hack was only required when we had hint text in the legends, which we no longer recommend.
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1548
NickColley
changed the title
36degrees
approved these changes
Sep 3, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hack was only required when we had hint text in the legends, which we no longer recommend.
I found this one hard to test since I could not reproduce the original issue, this was my approach:
I have tested the Labels, legends and headings example page cross browser, and it seems to be good:
https://www.browserstack.com/screenshots/a1c3019648921af4ae59eb1a0a100a1570104b82
I've also checked the
document.body.clientHeightbefore and after in Safari (webkit) and they're the same, which suggests no layout has changed.Fixes #1239