Abstracts database storage & Status page UI #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ab6a71d.
gosom
changed the title
ngoduykhanh
requested changes
Aug 24, 2021
Comment on lines
-13
to
-17
| ports: | ||
| - 5000:5000 |
There was a problem hiding this comment.
Why don't we want to expose the port here?
There was a problem hiding this comment.
Hi @ngoduykhanh , thanks for the review.
In order to get the status from the wg command the docker-compose runs with network-mode host.
This means that we do not need to expose any port
|
Thanks @gosom for the PR. I've left a few comments there :-) |
ngoduykhanh
approved these changes
Aug 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an IStore interface and an implementation of the current json storage.
This will help adding support for other databases like sqlite
Added also a Status page which displays all the peers
sample of how it looks like here:
https://prnt.sc/1p5oagi