-
-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change to sqlite or other relational database #75
Comments
Hi @Computroniks , this PR [ https://github.com//pull/88 ] abstracts the storage. |
Great, I will get on with this in the next few weeks. Thanks for the info on the pr |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Well, it's been a while. Sorry for not working on this. I got distracted with other projects and kind of forgot. I am going to start implementing this today and hopefully I should have it done by mid next week. At first I am only going to add support for MySQL/MariaDB with SQLite and PostgreSQL perhaps comming later. I think I will add the settings for the DB as commandline flags/environment variables. Again, sorry for neglecting this issue for so long. |
Currently a number of JSON files are used in order to save user data. Would it be worth moving to a relational database system such as sqlite? This would have a few advantages over the current JSON files, particularly as there would now only be one file. There would be some issues though with the current situation in terms of changing the admin password. It would require some utility either in the web interface or terminal to change the password.
It could also be an idea to use enviroment variables or a .env file to pass some settings for a remote db server such as mariadb allowing the user to use their central database instead of local storage (perhaps this is a step too far for now).
I would be willing to work on this but just want to see other peoples opinions before I do.
The text was updated successfully, but these errors were encountered: