Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove pytest-profiling from requirements.txt for tests #6659

Merged
merged 2 commits into from
Oct 15, 2024
Merged

remove pytest-profiling from requirements.txt for tests #6659

merged 2 commits into from
Oct 15, 2024

Conversation

AlexFenlon
Copy link
Contributor

@AlexFenlon AlexFenlon commented Oct 15, 2024 •
edited
Loading

Proposed changes

resolves comment from #6651: comment here

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@AlexFenlon AlexFenlon requested a review from a team as a code owner October 15, 2024 10:27
@github-actions github-actions bot added the python Pull requests that update Python code label Oct 15, 2024
@AlexFenlon AlexFenlon requested a review from j1m-ryan October 15, 2024 10:28
@AlexFenlon AlexFenlon enabled auto-merge (squash) October 15, 2024 10:30
@AlexFenlon AlexFenlon merged commit 54b720c into main Oct 15, 2024
79 checks passed
@AlexFenlon AlexFenlon deleted the test/remove-profiling branch October 15, 2024 11:24
@vepatel vepatel mentioned this pull request Oct 18, 2024
Merged
6 tasks
@pdabelf5 pdabelf5 added skip changelog Pull requests that don't need to be added to the changelog and removed python Pull requests that update Python code labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdabelf5 pdabelf5 pdabelf5 approved these changes

@vepatel vepatel vepatel approved these changes

@j1m-ryan j1m-ryan j1m-ryan approved these changes

Assignees
No one assigned
Labels
skip changelog Pull requests that don't need to be added to the changelog
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexFenlon @j1m-ryan @vepatel @pdabelf5