Update VirtualServer to ignore CRL for EgressMTLS #3737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
for more information, see https://pre-commit.ci
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## main #3737 +/- ##
==========================================
+ Coverage 52.37% 52.41% +0.03%
==========================================
Files 59 59
Lines 16898 16902 +4
==========================================
+ Hits 8851 8859 +8
+ Misses 7750 7748 -2
+ Partials 297 295 -2
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lucacome
previously requested changes
Apr 17, 2023
That would be the right thing to do. |
|
@brianehlert @lucacome We only added support for CRLs with IngressMTLs but not EgressMTLs. |
|
To close this conversation, we will be adding proper EgressMTLS support for CRL to match IngressMTLS behavior. |
vepatel
approved these changes
Apr 25, 2023
jjngx
approved these changes
Apr 25, 2023
ciarams87
approved these changes
Apr 26, 2023
lucacome
pushed a commit
that referenced
this pull request
May 4, 2023
* Update VirtualServer to ignore CRL for EgressMTLS * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Un-comment tests * Fix crt and crl path in test and fix nill slice reference * Update data files for egress MTLS tests * Remove VSR python test * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Add new app.yaml file for EgressMTLS tests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 87b8a58)
lucacome
added a commit
that referenced
this pull request
May 4, 2023
Update VirtualServer to ignore CRL for EgressMTLS (#3737) * Update VirtualServer to ignore CRL for EgressMTLS * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Un-comment tests * Fix crt and crl path in test and fix nill slice reference * Update data files for egress MTLS tests * Remove VSR python test * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Add new app.yaml file for EgressMTLS tests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 87b8a58) Co-authored-by: Shaun <s.odonovan@f5.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This change updates the logic which applies policies to VirtualServer to ignore CRL for EgressMTLS.
Resolves #3732
Checklist
Before creating a PR, run through this checklist and mark each as complete.