-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nginx.org/ca secret type & crl field to IngressMTLS to support CRL #3632
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3632 +/- ##
==========================================
+ Coverage 52.31% 52.33% +0.01%
==========================================
Files 59 59
Lines 16853 16880 +27
==========================================
+ Hits 8817 8834 +17
- Misses 7741 7749 +8
- Partials 295 297 +2
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Proposed changes
This change updates both the
nginx.org/ca
secret type and theingressMTLS
policy type to provide users a means to configure a Certificate Revocation List.The CRL can be configured in one of two ways.
nginx.org/ca
secret type using theca.crl
crl
field in theingressMTLS
policy spec providing the name of the CRL. This option assumes that the crlwebapp.crl
is provided by the users to/etc/nginx/secrets
Checklist
Before creating a PR, run through this checklist and mark each as complete.