Get nginx container id from labelled container #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not tested 100% yet, when I test it in docker compose v3 I'll post a comment. Feel free to comment on this PR in the meantime. |
|
@emmetog It's fully functional and completely compatible with docker compose v3. Thanks for your PR 👍 |
teohhanhui
reviewed
Apr 4, 2017
README.md
Outdated
| @@ -30,14 +30,15 @@ $ docker run -d -p 80:80 -p 443:443 \ | |||
| -v /etc/nginx/vhost.d \ | |||
| -v /usr/share/nginx/html \ | |||
| -v /var/run/docker.sock:/tmp/docker.sock:ro \ | |||
| --label jrcs.nginx_letsencrypt_companion.is_proxy=true \ | |||
There was a problem hiding this comment.
It should use a fully qualified domain name, i.e. com.github.jrcs.letsencrypt_nginx_proxy_companion.nginx_proxy=true
There was a problem hiding this comment.
Yes it will better to use a fully qualified domain name.
@emmetog can you make the changes ?
This was referenced May 3, 2017
This was referenced Jul 8, 2017
Closed
teohhanhui
reviewed
Jul 8, 2017
| @@ -30,14 +30,15 @@ $ docker run -d -p 80:80 -p 443:443 \ | |||
| -v /etc/nginx/vhost.d \ | |||
| -v /usr/share/nginx/html \ | |||
| -v /var/run/docker.sock:/tmp/docker.sock:ro \ | |||
| --label com.github.jrcs.letsencrypt_nginx_proxy_companion.nginx_proxy=true \ | |||
There was a problem hiding this comment.
There's no need for =true. Just a plain label is enough. It doesn't have to be a key-value pair.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #170