Compatibility with docker-compose v3

[joantune]

Hi!

First of all, kudos for the great work and container.

Currently, this container is not supported by docker-compose v3, because this new compose version has no volumes_from which is needed at:
https://github.com/JrCs/docker-letsencrypt-nginx-proxy-companion/blob/master/app/entrypoint.sh#L28

Any ideas on how to get the container's id any other way? I'm happy to do a PR if I have some pointers

I also asked that on an issue on docker-compose just now:

docker/compose#4379 (comment)

I don't know the rational for taking out a feature from compose, but I hope it's a good one on behalf of them, otherwise it kinda disencourages one to use it in the first place (IMO the docker engine and docker compose should have the same options possible)

For everyone else stuck on this, for now, just use v2.

[joantune]

It seems that this the way to go:

docker/compose#4379 (comment)

I can try to use the volumes from, and if it fails, use the label. Should I proceed with a PR?

[mikumi]

@joantune I am curious how you solved this, I haven't figured it out yet :)

[JrCs]

@joantune yes you can proceed with a PR to use labels instead of volumes_from to get the container id.

[cweilguny]

I did a setup using named volumes, without volumes_from. It works, don't know how as the entrypoint.sh of the letsencrypt container clearly uses VolumeFrom.

Here is the setup as a gist: https://gist.github.com/netdesk/c1db2985b542f9916995139318e5a7ce

The gist also includes a docker-compose setup for gitlab. One could include this in the nginx-proxy setup, but I wanted to separate concerns and the gitlab setup basically has nothing to do with the nginx-proxy thing.

EDIT: ah, nvm. As I'm using separate containers for nginx and docker-gen, i already used NGINX_DOCKER_GEN_CONTAINER to identify the docker-gen container. Then get_nginx_proxy_cid and VolumesFrom is never used.