Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gene Variant Module #12

Merged
merged 2 commits into from
Jan 23, 2020
Merged

Gene Variant Module #12

merged 2 commits into from
Jan 23, 2020

Conversation

jaybee84
Copy link
Collaborator

@jaybee84 jaybee84 commented Jan 23, 2020 •
edited
Loading

  • New PR related to PR Adding gene_var module with lollipop plot #10
  • Added smaller dataset for prototyping ease
  • Maftools is still printing messages to console in cases where it find more than 1 RefSeqId for any gene. Currently it does not allow silencing of these user notifications. We may want to explore other plotting functions with more control, or maybe allow these messages to go through to the app UI to notify the user. Keeping as is for now, as we explore options.

allaway
allaway approved these changes Jan 23, 2020
View reviewed changes
Copy link
Collaborator

@allaway allaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks/works great! I guess the next step is to wire this up so it is also being filtered by specimenID.

@allaway allaway merged commit 842be4c into nf-osi:develop Jan 23, 2020
@jaybee84
Copy link
Collaborator Author

jaybee84 commented Jan 23, 2020 •
edited
Loading

Yup.. working on that :)

For prototyping it would have to be from JHU biobank :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allaway allaway allaway approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaybee84 @allaway