-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding gene_var module with lollipop plot #10
Conversation
Update README.md
more tidying
update master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! For prototyping purposes, can you make the data files much smaller (<5mb?). It takes a really long time to load the app - for an app in production this actually isn't that big of a deal because it only has to load once running on a server, but for working on the app it makes it a lot slower to test small changes.
I'd suggest just filtering the files down to something like: NF1, NF2, PTEN, SUZ12, EED, KRAS, NRAS, P53 for starters.
Side note, I got this warning for one of the ORFs:
Warning: Error in maftools::lollipopPlot: Structure for protein C1orf170 not found.
[No stack trace available]
Not sure where this Rproj file is coming from, but the project file is already in the root directory.
|
||
output$lollipop_plot <- shiny::renderPlot({ | ||
|
||
maftools::lollipopPlot( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this function seems to be printing to console, if this can be turned off that might speed stuff up a bit (especially when we scale up to bigger files)!
1: HES4 NM_021170 NP_066993 221
2: HES4 NM_001142467 NP_001135939 247
Using longer transcript NM_001142467 for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will do
I just fixed this code chunk, before it had no helpful information, sorry! |
Thanks! That error is being thrown because maftools cant find a mapped protein structure of the gene C1orf170 to plot the lollipops on! Looking into how to fix that... |
starting a new pull request due to some push hiccups. |
No description provided.